Issue 6910025: ARM: Add GYP variables to control V8 code generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6910025: ARM: Add GYP variables to control V8 code generation (Closed)

Created:
9 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Add GYP variables to control V8 code generation Added the GYP variables: v8_can_use_unaligned_accesses v8_use_arm_eabi_hardfloat Refer to the comments in v8.gyp on their uses. R=karlklose@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7769

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -5 lines)			Patch
	M	SConstruct	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/gyp/v8.gyp	View	1	4 chunks	+41 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM. http://codereview.chromium.org/6910025/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/6910025/diff/1/tools/gyp/v8.gyp#newcode52 tools/gyp/v8.gyp:52: # EABI calling convention where double arguments are ...

9 years, 7 months ago (2011-05-04 06:05:14 UTC) #2

Søren Thygesen Gjesse

9 years, 7 months ago (2011-05-04 06:24:41 UTC) #3

http://codereview.chromium.org/6910025/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/6910025/diff/1/tools/gyp/v8.gyp#newcode52
tools/gyp/v8.gyp:52: # EABI calling convention where double arguments are passe
in VFP registers.
On 2011/05/04 06:05:14, Karl Klose wrote:
> passe -> passed

Done.

Expand Messages | Collapse Messages