Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 6905098: ARM: Support hardfloat in SCons build and make it a build time setting (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

ARM: Support hardfloat in SCons build and make it a build time setting Add option armeabi to the SCons build for selecting the floating point variant to use. Also add externally defined CCFLAGS environment for all targets. Run test.py with option -S armeabi=hardfloat to test with hardfloat enabled. Make selecting hardfloat EABI variant a build-time option instead of a runtime option. Add a simple check of the EABI variant during V8 initialization to exit if the compilation was not configured correctly. The reason for this is that GCC does not provide a compile time symbol defining the EABI variant. This check is not fool-proof as it cannot check the compilation configuration used for the snapshot if any. R=karlklose@chromium.org, erik.corry@gmail.com BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7715

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments from Karl #

Patch Set 3 : Added CAN_USE_VFP_INSTRUCTIONS when hardfloat is used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -32 lines) Patch
M SConstruct View 1 2 8 chunks +63 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 3 chunks +42 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/test.py View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-28 14:46:57 UTC) #1
Karl Klose
LGTM. http://codereview.chromium.org/6905098/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/6905098/diff/1/SConstruct#newcode302 SConstruct:302: # This is to silence warnings about ABI ...
9 years, 7 months ago (2011-04-29 06:25:46 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-04-29 06:55:13 UTC) #3
http://codereview.chromium.org/6905098/diff/1/SConstruct
File SConstruct (right):

http://codereview.chromium.org/6905098/diff/1/SConstruct#newcode302
SConstruct:302: # This is to silence warnings about ABI changes thes Some
versions of the
On 2011/04/29 06:25:46, Karl Klose wrote:
> that some?

Done.

http://codereview.chromium.org/6905098/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/6905098/diff/1/src/platform-linux.cc#newcode202
src/platform-linux.cc:202: // Simple helper function to detect whether the C
code is compiler with
On 2011/04/29 06:25:46, Karl Klose wrote:
> compiler -> compiled

Done.

Powered by Google App Engine
This is Rietveld 408576698