Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 6904164: ARM: Changed the handling of compiletime CPU feature detection (Closed)

Created:
9 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

ARM: Changed the handling of compiletime CPU feature detection Always use CpuFeaturesImpliedByCompiler() when selecting CPU features. This checks both for CAN_USE_ARMV7_INSTRUCTIONS and CAN_USE_VFP_INSTRUCTIONS and for GCC preprocessor symbols. This will support using the CAN_USE_XXX for a simulator build used for generating a snapshot followed by a crosscompile using -march= and -mfpu= for selecting the (minimal) target device CPU features. The snapshot will use instructions based on the CAN_USE_XXX whereas the target will at least use features based on both CAN_USE_XXX and -march= and -mfpu=, but will try runtime CPU feature detection a well looking for somethis better. Remove the compiler based CPU feature detection from the OS::CpuFeaturesImpliedByPlatform() as it did not belong there. Also was already in the CpuFeaturesImpliedByCompiler(). Add the variable 'v8_can_use_vfp_instructions' to the GYP file which can be used to turn on CAN_USE_VFP_INSTRUCTIONS when building V8. I did not add any -mfpu= cflags for this, as there are several options here (e.g. vfp and neon). R=erik.corry@gmail.com, karlklose@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +26 lines, -13 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-02 11:32:53 UTC) #1
Karl Klose
LGTM.
9 years, 7 months ago (2011-05-02 12:36:32 UTC) #2
Erik Corry
9 years, 7 months ago (2011-05-03 06:49:25 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698