Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 6834020: ARM: Fix a number of issues with running without VFPv3 support (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix a number of issues with running without VFPv3 support The type recording binary operations stub contained a number of issues which broke V8 when running without VFPv3 supoort. 1. The order of the high/low words of doubles in core register pairs where wrong 2. Missing allocation of a heap number for the result 3. Missing call to runtime Added the option for printing the double values in register pairs to the simulator. R=karlklose@chromium.org BUG=v8:1315 TEST= Committed: http://code.google.com/p/v8/source/detail?r=7603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -33 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 11 chunks +42 lines, -31 lines 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-13 10:41:38 UTC) #1
Karl Klose
9 years, 8 months ago (2011-04-13 11:24:56 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698