Issue 6825037: ARM: Always enable ARMv7 when VFPv3 is enabled.

Issue 6825037: ARM: Always enable ARMv7 when VFPv3 is enabled. (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Rodolph Perfetta

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Always enable ARMv7 when VFPv3 is enabled. R=vegorov@chromium.org, rodolph.perfetta@gmail.com BUG=v8:1317 TEST= Committed: http://code.google.com/p/v8/source/detail?r=7580

Patch Set 2 : Additional changes #

Total comments: 4

Patch Set 3 : Added missing file #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	src/arm/assembler-arm.cc	View	1	3 chunks	+11 lines, -9 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform-linux.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rodolph Perfetta

http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#newcode63 src/arm/assembler-arm.cc:63: #if defined(__VFP_FP__) && !defined(__SOFTFP__) This would be true for ...

9 years, 8 months ago (2011-04-11 12:48:55 UTC) #3

Søren Thygesen Gjesse

9 years, 8 months ago (2011-04-11 14:10:25 UTC) #4

http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#new...
src/arm/assembler-arm.cc:63: #if defined(__VFP_FP__) && !defined(__SOFTFP__)
On 2011/04/11 12:48:55, Rodolph Perfetta wrote:
> This would be true for VFPv2 too.

I see, but that was what we had before. I can't seem to find any way to see from
gcc to distinguish.

http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#new...
src/arm/assembler-arm.cc:66: #ifdef CAN_USE_VFP_INSTRUCTIONS
On 2011/04/11 12:48:55, Rodolph Perfetta wrote:
> I can't find where CAN_USE_VFP_INSTRUCTIONS is defined.

This is defined in the SConstruct file when compiling for Android (maybe the gcc
used for compiling for Android did not define __VFP_FP__). We could consider
removing it, as the SCons based Android build is broken, and the Android
repository has a v8_shell target now.

Expand Messages | Collapse Messages