Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 6816054: ARM: Fix a crash bug in code for %_IsStringWrapperSafeForDefaultValueOf (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix a crash bug in code for %_IsStringWrapperSafeForDefaultValueOf Turned out out that the setting of bit Map::kStringWrapperSafeForDefaultValueOf in Map::kStringWrapperSafeForDefaultValueOf was not done on the map but in some other memory location causing crashes. R=vegorov@chromium.org BUG=none TEST=mozilla/data/js1_2/String/slice.js (crashed only on ARM hardware) Committed: http://code.google.com/p/v8/source/detail?r=7558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-08 11:33:52 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-04-08 11:36:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698