Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 6788009: Revert "Never use classic code generator." (Closed)

Created:
9 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Never use classic code generator." This reverts r7469 which might have caused the timeouts on the buildbot. TBR=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -32 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ast.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/compiler.cc View 4 chunks +53 lines, -8 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/v8.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/test.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-01 14:37:41 UTC) #1
Mads Ager (chromium)
9 years, 8 months ago (2011-04-01 14:38:16 UTC) #2
LGTM, thanks.

I'll investigate tonight.

Powered by Google App Engine
This is Rietveld 408576698