Extend crankshaft support for global stores

Extend crankshaft support for global stores

All global stores are now supported in crankshaft by using the normal store IC when other optimizations are not possible due to the state of the global object.

R=fschneider@chromium.org

BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=7495

[fschneider, 2011-04-04 13:47:50]

LGTM with comments.

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.cc#newcode1758
src/arm/lithium-arm.cc:1758: return MarkAsCall(DefineFixed(result, r0), instr);
No DefineFixed needed.

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.h#newcode1298
src/arm/lithium-arm.h:1298: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 2, 0> {
<0, 2, 0>

http://codereview.chromium.org/6693066/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/hydrogen.cc#newcode3317
src/hydrogen.cc:3317: //ast_context()->ReturnInstruction(instr, expr->id());
Remove commented code.

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.cc#newcod...
src/ia32/lithium-ia32.cc:1777: return MarkAsCall(DefineFixed(result, eax),
instr);
No need for DefineFixed here.

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.h#newcode...
src/ia32/lithium-ia32.h:1332: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 3, 0> {
StoreGlobalGeneric should not need a result operand: LTemplateInstruction<0, 3,
0>

(same for other platforms)

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (left):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2747: CpuFeatures::Scope scope(SSE2);
Accidental edit?

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.cc#newcode1746
src/x64/lithium-x64.cc:1746: return MarkAsCall(DefineFixed(result, rax), instr);
No DefineFixed needed (see also StoreNamedGeneric)

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.h#newcode1284
src/x64/lithium-x64.h:1284: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 2, 0> {
<0, 2, 0>

[Søren Thygesen Gjesse, 2011-04-04 14:16:34]

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.cc#newcode1758
src/arm/lithium-arm.cc:1758: return MarkAsCall(DefineFixed(result, r0), instr);
On 2011/04/04 13:47:50, fschneider wrote:
> No DefineFixed needed.

Done.

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6693066/diff/1/src/arm/lithium-arm.h#newcode1298
src/arm/lithium-arm.h:1298: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 2, 0> {
On 2011/04/04 13:47:50, fschneider wrote:
> <0, 2, 0>

Done.

http://codereview.chromium.org/6693066/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/hydrogen.cc#newcode3317
src/hydrogen.cc:3317: //ast_context()->ReturnInstruction(instr, expr->id());
On 2011/04/04 13:47:50, fschneider wrote:
> Remove commented code.

Done.

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.cc#newcod...
src/ia32/lithium-ia32.cc:1777: return MarkAsCall(DefineFixed(result, eax),
instr);
On 2011/04/04 13:47:50, fschneider wrote:
> No need for DefineFixed here.

Done.

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):

http://codereview.chromium.org/6693066/diff/1/src/ia32/lithium-ia32.h#newcode...
src/ia32/lithium-ia32.h:1332: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 3, 0> {
On 2011/04/04 13:47:50, fschneider wrote:
> StoreGlobalGeneric should not need a result operand: LTemplateInstruction<0,
3,
> 0>
> 
> (same for other platforms)

Done.

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (left):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2747: CpuFeatures::Scope scope(SSE2);
On 2011/04/04 13:47:50, fschneider wrote:
> Accidental edit?

I don't think so, SSE2 is always available on x64, and this line is the only
reference to it.

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.cc#newcode1746
src/x64/lithium-x64.cc:1746: return MarkAsCall(DefineFixed(result, rax), instr);
On 2011/04/04 13:47:50, fschneider wrote:
> No DefineFixed needed (see also StoreNamedGeneric)

Done.

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-x64.h#newcode1284
src/x64/lithium-x64.h:1284: class LStoreGlobalGeneric: public
LTemplateInstruction<1, 2, 0> {
On 2011/04/04 13:47:50, fschneider wrote:
> <0, 2, 0>

Done.

[fschneider, 2011-04-04 14:20:31]

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (left):

http://codereview.chromium.org/6693066/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2747: CpuFeatures::Scope scope(SSE2);
On 2011/04/04 14:16:34, Søren Gjesse wrote:
> On 2011/04/04 13:47:50, fschneider wrote:
> > Accidental edit?
> 
> I don't think so, SSE2 is always available on x64, and this line is the only
> reference to it.

You're right - I overlooked that this is the x64 file.