fix PackageLibraryManager to resolve self links to right file

fix PackageLibraryManager to resolve self links to right file
Committed: https://code.google.com/p/dart/source/detail?r=12593

[danrubel, 2012-09-19 18:35:52]

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/PackageLibraryManager.java (right):

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:276: int index
= absolutePath.indexOf(PACKAGES_DIRECTORY_NAME);
This check will incorrectly flag /mypackages/ and /packages2/

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:280: if
(file.getCanonicalPath().contains(absolutePath)){
Should we always return the canonical path for all symlinks in "packages"
directories?

[keertip, 2012-09-19 19:01:58]

PTAL

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/PackageLibraryManager.java (right):

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:276: int index
= absolutePath.indexOf(PACKAGES_DIRECTORY_NAME);
Remove - no longer needed.

On 2012/09/19 18:35:52, danrubel wrote:
> This check will incorrectly flag /mypackages/ and /packages2/

http://codereview.chromium.org/10951031/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:280: if
(file.getCanonicalPath().contains(absolutePath)){
As discussed, yes, we should always return canonical path

On 2012/09/19 18:35:52, danrubel wrote:
> Should we always return the canonical path for all symlinks in "packages"
> directories?

[danrubel, 2012-09-19 19:13:25]

lgtm

http://codereview.chromium.org/10951031/diff/6002/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/PackageLibraryManager.java (right):

http://codereview.chromium.org/10951031/diff/6002/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:51: private
static final String PACKAGES_DIRECTORY_NAME = "packages";
Is this needed?

[keertip, 2012-09-19 19:15:21]

http://codereview.chromium.org/10951031/diff/6002/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/PackageLibraryManager.java (right):

http://codereview.chromium.org/10951031/diff/6002/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/PackageLibraryManager.java:51: private
static final String PACKAGES_DIRECTORY_NAME = "packages";
Oops! missed that. Removed.

On 2012/09/19 19:13:25, danrubel wrote:
> Is this needed?