load sdk libraries defined in libraries.dart

load sdk libraries defined in libraries.dart
Committed: https://code.google.com/p/dart/source/detail?r=11838

[danrubel, 2012-09-04 18:52:21]

LGTM with a few modifications

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:32: private
Map<String, DartLibrary> declaredLibraries;
Is this needed as a field? Is it used in more places than a single method? If
yes, then keep it, otherwise please remove.

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:132: String
path = entry.getValue().getPath();
If category is "Internal" then we should skip the entry.

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:146: if
(shortName.endsWith(":")) {
shortName will never end with ":" because all libraries are explicitly listed.
This section of code can be completely removed.

[keertip, 2012-09-04 19:23:13]

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:32: private
Map<String, DartLibrary> declaredLibraries;
On 2012/09/04 18:52:22, danrubel wrote:
> Is this needed as a field? Is it used in more places than a single method? If
> yes, then keep it, otherwise please remove.

Done.

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:132: String
path = entry.getValue().getPath();
On 2012/09/04 18:52:22, danrubel wrote:
> If category is "Internal" then we should skip the entry.

Done.

https://chromiumcodereview.appspot.com/10916099/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:146: if
(shortName.endsWith(":")) {
On 2012/09/04 18:52:22, danrubel wrote:
> shortName will never end with ":" because all libraries are explicitly listed.
> This section of code can be completely removed.

Done.

[danrubel, 2012-09-04 19:28:01]

lgtm

https://chromiumcodereview.appspot.com/10916099/diff/5001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10916099/diff/5001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:130: if
(entry.getValue().getCategory().equals("Internal")){
Will getCategory() ever return null ?
Should the .equals be flipped to account for this?

[keertip, 2012-09-04 19:32:41]

https://chromiumcodereview.appspot.com/10916099/diff/5001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10916099/diff/5001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:130: if
(entry.getValue().getCategory().equals("Internal")){
On 2012/09/04 19:28:01, danrubel wrote:
> Will getCategory() ever return null ?
> Should the .equals be flipped to account for this?

It will not return null - default setting is "Shared"