Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10912087: change sdk layout, fixes to darta/editor tests to work with new layout (Closed)

Created:
8 years, 3 months ago by keertip
Modified:
8 years, 3 months ago
Reviewers:
dgrove, pquitslund, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

change sdk layout, fixes to darta/editor tests to work with new layout Committed: https://code.google.com/p/dart/source/detail?r=11882

Patch Set 1 #

Total comments: 7

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -123 lines) Patch
M compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java View 1 2 chunks +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderAnyTest.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M lib/_internal/libraries.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M lib/config/import_any.config View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 2 8 chunks +26 lines, -118 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
keertip
8 years, 3 months ago (2012-09-04 21:58:03 UTC) #1
pquitslund
LGTM!
8 years, 3 months ago (2012-09-04 21:59:19 UTC) #2
danrubel
LGTM but rather than modifying import_any.config can we just delete the entire config directory if ...
8 years, 3 months ago (2012-09-04 22:07:44 UTC) #3
pquitslund
On 2012/09/04 22:07:44, danrubel wrote: > LGTM but rather than modifying import_any.config can we just ...
8 years, 3 months ago (2012-09-04 22:08:20 UTC) #4
pquitslund
On 2012/09/04 22:08:20, pquitslund wrote: > On 2012/09/04 22:07:44, danrubel wrote: > > LGTM but ...
8 years, 3 months ago (2012-09-04 22:20:02 UTC) #5
dgrove
https://chromiumcodereview.appspot.com/10912087/diff/1/lib/config/import_any.config File lib/config/import_any.config (right): https://chromiumcodereview.appspot.com/10912087/diff/1/lib/config/import_any.config#newcode40 lib/config/import_any.config:40: dart\:nativewrappers = html/nativewrappers.dart this needs to be html/dartium/nativewrappers.dart https://chromiumcodereview.appspot.com/10912087/diff/1/tools/create_sdk.py ...
8 years, 3 months ago (2012-09-05 00:05:56 UTC) #6
keertip
https://chromiumcodereview.appspot.com/10912087/diff/1/lib/config/import_any.config File lib/config/import_any.config (right): https://chromiumcodereview.appspot.com/10912087/diff/1/lib/config/import_any.config#newcode40 lib/config/import_any.config:40: dart\:nativewrappers = html/nativewrappers.dart The editor no longer uses the ...
8 years, 3 months ago (2012-09-05 15:35:18 UTC) #7
dgrove
8 years, 3 months ago (2012-09-05 16:01:48 UTC) #8
lgtm after one nit.

Powered by Google App Engine
This is Rietveld 408576698