Issue 10907096: modify files view to use declared sdk libraries

Issue 10907096: modify files view to use declared sdk libraries (Closed)

Created:
8 years, 3 months ago by keertip

Modified:
8 years, 3 months ago

Reviewers:
devoncarew, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

modify files view to use declared sdk libraries Committed: https://code.google.com/p/dart/source/detail?r=12042

Patch Set 2 : '' #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -90 lines)			Patch
M	compiler/java/com/google/dart/compiler/PackageLibraryManager.java	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/SystemLibrary.java	View		3 chunks	+24 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View		3 chunks	+17 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java	View	1	1 chunk	+0 lines, -65 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java	View		3 chunks	+23 lines, -16 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartLibraryNode.java	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

devoncarew

lgtm https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java (right): https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java#newcode33 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java:33: super(shortName, host, pathToLib, null, "Shared", true, false); category ...

8 years, 3 months ago (2012-09-06 18:37:39 UTC) #2

keertip

https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java (right): https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java#newcode33 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java:33: super(shortName, host, pathToLib, null, "Shared", true, false); category = ...

8 years, 3 months ago (2012-09-06 20:22:59 UTC) #3

danrubel

lgtm https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java (right): https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java#newcode32 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java:32: public BundledSystemLibrary(String shortName, String host, String pathToLib, Bundle ...

8 years, 3 months ago (2012-09-06 22:05:58 UTC) #4

keertip

8 years, 3 months ago (2012-09-07 15:33:59 UTC) #5

https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java
(right):

https://chromiumcodereview.appspot.com/10907096/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibrary.java:32:
public BundledSystemLibrary(String shortName, String host, String pathToLib,
Bundle bundle) {
Thanks for catching that. It is not being used - removed.

On 2012/09/06 22:05:58, danrubel wrote:
> Is this class used? Can it be removed?

Expand Messages | Collapse Messages