Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 10823060: fix resolving import uri's for packages (Closed)

Created:
8 years, 4 months ago by keertip
Modified:
8 years, 4 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix resolving import uri's for packages Committed: https://code.google.com/p/dart/source/detail?r=10077

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M compiler/java/com/google/dart/compiler/SystemLibraryManager.java View 6 chunks +21 lines, -4 lines 1 comment Download
M compiler/java/com/google/dart/compiler/UrlLibrarySource.java View 2 chunks +15 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
keertip
8 years, 4 months ago (2012-07-27 20:42:42 UTC) #1
danrubel
Adding some tests to SystemLibraryManagerTest would be good as this will not be the last ...
8 years, 4 months ago (2012-07-31 16:49:48 UTC) #2
danrubel
8 years, 4 months ago (2012-07-31 16:53:58 UTC) #3
Per discussion, LGTM with tests in subsequent CL.

Powered by Google App Engine
This is Rietveld 408576698