Issue 10821119: set package root after creating configuration, since defualt compiler configuration is used by an...

Issue 10821119: set package root after creating configuration, since defualt compiler configuration is used by an... (Closed)

Created:
8 years, 4 months ago by keertip

Modified:
8 years, 4 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

set package root after creating configuration, since defualt compiler configuration is used by analysis server too. Committed: https://code.google.com/p/dart/source/detail?r=10095

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/DartCompiler.java	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java	View		1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10821119/diff/1/compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java File compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java (right): https://chromiumcodereview.appspot.com/10821119/diff/1/compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java#newcode1 compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java:1: // Copyright (c) 2011, the Dart project authors. ...

8 years, 4 months ago (2012-07-31 22:20:05 UTC) #2

keertip

https://chromiumcodereview.appspot.com/10821119/diff/1/compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java File compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java (right): https://chromiumcodereview.appspot.com/10821119/diff/1/compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java#newcode1 compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java:1: // Copyright (c) 2011, the Dart project authors. Please ...

8 years, 4 months ago (2012-07-31 22:22:35 UTC) #3

lgtm

Expand Messages | Collapse Messages