changes to SystemLibraryManager to support list of roots

changes to SystemLibraryManager to support list of roots  
Committed: https://code.google.com/p/dart/source/detail?r=9786

[danrubel, 2012-07-20 14:38:14]

https://chromiumcodereview.appspot.com/10809023/diff/2001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10809023/diff/2001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:328: }
if this is a package URI, but an existing file cannot be found in any of the
roots, then we need to return a file URI for a not-yet-existing file in the
package root that contains the users files currently checked out and being
edited.

https://chromiumcodereview.appspot.com/10809023/diff/2001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java
(right):

https://chromiumcodereview.appspot.com/10809023/diff/2001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:151:
// TODO(keertip): fix test, this will fail, we now check for file exists
Once earlier comment is addressed, this code should work and should be
uncommented.

[keertip, 2012-07-20 17:38:17]

PTAL, have made the changes as discussed.

https://chromiumcodereview.appspot.com/10809023/diff/2001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10809023/diff/2001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:328: }
On 2012/07/20 14:38:15, danrubel wrote:
> if this is a package URI, but an existing file cannot be found in any of the
> roots, then we need to return a file URI for a not-yet-existing file in the
> package root that contains the users files currently checked out and being
> edited.

Done.

https://chromiumcodereview.appspot.com/10809023/diff/2001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java
(right):

https://chromiumcodereview.appspot.com/10809023/diff/2001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:151:
// TODO(keertip): fix test, this will fail, we now check for file exists
On 2012/07/20 14:38:15, danrubel wrote:
> Once earlier comment is addressed, this code should work and should be
> uncommented.

Done.

[danrubel, 2012-07-20 17:58:41]

lgtm

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:50: public
static final File DEFAULT_PACKAGE_ROOT = new File("packages");
Convert to file with absolute path?

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:110: for (File
file : packageRoots){
Rather than duplicating logic here, call setPackageRoots(...)

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:289:
this.packageRoots = roots;
Convert incoming to files with absolute paths?

[keertip, 2012-07-20 19:42:13]

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:50: public
static final File DEFAULT_PACKAGE_ROOT = new File("packages");
done in setPackageRoots

On 2012/07/20 17:58:42, danrubel wrote:
> Convert to file with absolute path?

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:110: for (File
file : packageRoots){
On 2012/07/20 17:58:42, danrubel wrote:
> Rather than duplicating logic here, call setPackageRoots(...)

Done.

https://chromiumcodereview.appspot.com/10809023/diff/6002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:289:
this.packageRoots = roots;
On 2012/07/20 17:58:42, danrubel wrote:
> Convert incoming to files with absolute paths?

Done.