Issue 10540162: fix for correct resolution of package: uris

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540162: fix for correct resolution of package: uris (Closed)

Created:
8 years, 6 months ago by keertip

Modified:
8 years, 6 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

fix for correct resolution of package: uris Committed: https://code.google.com/p/dart/source/detail?r=8694

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/SystemLibraryManager.java	View		1 chunk	+9 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

I have no idea whether this is right, but given that it solves the immediate ...

8 years, 6 months ago (2012-06-14 20:30:16 UTC) #2

danrubel

8 years, 6 months ago (2012-06-14 21:15:23 UTC) #3

Not sure I understand the problem but LGTM if it solves it.

https://chromiumcodereview.appspot.com/10540162/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10540162/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:290: if
(uri.getHost() != null){
Please update the comment to include a URI in which host is null.

Expand Messages | Collapse Messages